Skip to content

docs: add htmlexample shortcode#2412

Merged
bennypowers merged 10 commits intomainfrom
docs/html-examples-disclosure
Apr 18, 2023
Merged

docs: add htmlexample shortcode#2412
bennypowers merged 10 commits intomainfrom
docs/html-examples-disclosure

Conversation

@zeroedin
Copy link
Contributor

@zeroedin zeroedin commented Mar 7, 2023 •
edited
Loading

What I did

  1. Added {% htmlexample %} short code to display HTML example code in a disclosure.

Testing Instructions

  1. View Deploy preview and look at the usage of the shortcodes for hiding and displaying the HTML examples.

Notes to Reviewers

I think we might need to apply some style to the <details> generated by the shortcode. Ideas welcome!

@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5caf4d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added work in progress POC / Not ready for review doc labels Mar 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6022f0e
😎 Deploy Preview https://deploy-preview-2412--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 7, 2023
@zeroedin zeroedin marked this pull request as ready for review March 8, 2023 14:54
@zeroedin zeroedin removed work in progress POC / Not ready for review AT passed Automated testing has passed doc labels Mar 9, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 9, 2023
@zeroedin zeroedin assigned zeroedin and unassigned heyMP Mar 9, 2023
@brianferry
Copy link
Collaborator

brianferry commented Mar 9, 2023

I think we might need to apply some style to the

Details generated by the shortcode. Ideas welcome!

Might be worth making a pfe disclosure element as well as an rh-disclosure element down the line both using the <details> element.

@zeroedin
Copy link
Contributor Author

zeroedin commented Mar 9, 2023

image

@brianferry the fact that when you quoted this bit of text it actually turned into a details element is priceless.

@zeroedin zeroedin added this to the PatternFly Elements 2.x milestone Mar 16, 2023
@github-actions github-actions bot added the doc label Mar 16, 2023
brianferry
brianferry approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemurs Galloping Towards Munchies

@bennypowers bennypowers force-pushed the docs/html-examples-disclosure branch from 5b8155f to a53d20c Compare April 18, 2023 07:57
@bennypowers bennypowers merged commit 83165dd into main Apr 18, 2023
@bennypowers bennypowers deleted the docs/html-examples-disclosure branch April 18, 2023 08:07
@bennypowers bennypowers mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianferry brianferry brianferry approved these changes

@bennypowers bennypowers Awaiting requested review from bennypowers

@coreyvickery coreyvickery Awaiting requested review from coreyvickery

Assignees

@zeroedin zeroedin

Labels

AT passed Automated testing has passed ready to merge

Projects

None yet

Milestone

PatternFly Elements 2.x

Development

Successfully merging this pull request may close these issues.

4 participants

@zeroedin @brianferry @bennypowers @heyMP